Skip to content

New SDK update for Automation - 3.2.0-preview#4583

Merged
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
vrdmr:vameru-automation-new-sdk-320-preview
Jul 25, 2018
Merged

New SDK update for Automation - 3.2.0-preview#4583
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
vrdmr:vameru-automation-new-sdk-320-preview

Conversation

@vrdmr
Copy link
Copy Markdown
Member

@vrdmr vrdmr commented Jul 24, 2018

Description

Contains changes introduced in the following spec changes:
Azure/azure-rest-api-specs#3363
Azure/azure-rest-api-specs#3420

Other changes:

  • Enabled the Runbook tests and rerecorded them.
  • Bumped up the version of the SDK - 3.2.0-preview.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@vrdmr vrdmr mentioned this pull request Jul 24, 2018
Closed
9 tasks
@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented Jul 25, 2018

@vrdmr how come you have a breaking change in your stable API version for runbook spec?
is that something you intend to do in a stable version of API?

dsgouda
dsgouda approved these changes Jul 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Jul 25, 2018

@vrdmr will merge once you address @shahabhijeet 's comments

@vrdmr
Copy link
Copy Markdown
Member Author

vrdmr commented Jul 25, 2018

@shahabhijeet The changes in the Runbook resource are to revert the resource to its original shape (which were changed in Azure/azure-rest-api-specs#2466). The changes are in the RunbookContent (Get and Put) call to now use format:file, which in the SDK now Streams rather than string (which was failing earlier).

Please let me know if you have any more questions.

@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented Jul 25, 2018

@vrdmr are you saying the spec was incorrectly modeled? Hence you reverted back the model type?
If yes let's have a quick chat on IM and close on this PR.

@shahabhijeet
Copy link
Copy Markdown
Contributor

shahabhijeet commented Jul 25, 2018

@vrdmr from what we talked, this change is about restoring the old behavior and not introducing breaking change.

@shahabhijeet shahabhijeet merged commit 3b48090 into Azure:psSdkJson6 Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dsgouda dsgouda dsgouda approved these changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrdmr @shahabhijeet @dsgouda